dotnet / dotnet/arcade

Mac CRL hangs instead of bubbling up the error

Open
#16,305 9 comments 0 reactions 1 assignee Claimed by @chcosta View on GitHub
Dominant language
C#
Stars
729
Forks
397
Avg merge
3d 15m
Merged PRs (30d)
149

Description

- [ ] This issue is blocking
- [ ] This issue is causing unreasonable pain

We should bubble up errors and not hang. Here's an example

[Apply "fail open" workaround to FindDotNetCliPackage (#16293) · dotnet/arcade@4bb60de](https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdotnet%2Farcade%2Fcommit%2F4bb60deca10193c27f5bdf0a6afc5878ef558455&data=05%7C02%7Cmawilkie%40microsoft.com%7C7f28801f90094346e86b08de229b2771%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C638986246929240593%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=zZc6lKXPtjM1C4pHVDEV6F43VdmGCYMk3zszdsF720Y%3D&reserved=0)
[Use fail-open certificate revocation check in AzureDevOpsTask (#16280) · dotnet/arcade@3a7f017](https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdotnet%2Farcade%2Fcommit%2F3a7f017be1c42a4ecc516446977cf55d429cf390&data=05%7C02%7Cmawilkie%40microsoft.com%7C7f28801f90094346e86b08de229b2771%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C638986246929253842%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=OYGj5zec9D8R%2BoYKFAatrrogsFGHCfncpU1M5lJ8Oqg%3D&reserved=0)

Obviously it'd be good to make this as generic as possible.

Also, this probably something that is best put in httphandler, but I'm starting here in Arcade as it's where the issue reveals itself.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.