dotnet / dotnet/arcade

Arcade's signing settings are wrong when setting UsingToolXliff=false

Open
#15,857 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
C#
Stars
729
Forks
397
Avg merge
3d 15m
Merged PRs (30d)
149

Description

Looks like the old msbuild uses `AL` to produce satellite assemblies. AL doesn't support `publicsign` which Arcade targets rely on when building assemblies that sign with various PRSS-owned signing keys.

Arcade should either set `GenerateSatelliteAssembliesForCore` for all projects regardless of `UsingToolXliff` setting, or it should use a different value for `DelaySign` when running `AL`.

I'm not sure if `AL` has any features that would be missing from core approach of using `csc`. If not, then I'd suggest we just use `GenerateSatelliteAssembliesForCore` always.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.