dotnet / dotnet/arcade

[SignCheck] Avoid holding exclusive writes on log files

Open
#15,729 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C#
Stars
729
Forks
397
Avg merge
3d 15m
Merged PRs (30d)
149

Description

See https://github.com/dotnet/source-build/issues/5041

SignCheck currently holds exclusive writes on its log files, so when SignCheck times out, the following errors can occur when trying to access the log files:

```
The process cannot access the file 'D:\a\_work\1\a\SigningValidation\signcheck.log' because it is being used by another process.
[WARNING] Asset D:\a\_work\1\a\SigningValidation\signcheck.error.log failed to get process

The process cannot access the file 'D:\a\_work\1\a\SigningValidation\signcheck.error.log' because it is being used by another process.

[WARNING] Asset D:\a\_work\1\a\SigningValidation\signcheck.xml failed to get process
The process cannot access the file 'D:\a\_work\1\a\SigningValidation\signcheck.xml' because it is being used by another process
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.