dotnet / dotnet/arcade

Remove Windows PDB conversion

Open
#15,724 3 comments 1 reaction 0 assignees View on GitHub
Dominant language
C#
Stars
729
Forks
397
Avg merge
3d 15m
Merged PRs (30d)
149

Description

https://github.com/dotnet/arcade/blob/490307dc9bb09caf016b2fa96005ac8aaa89c4e7/src/Microsoft.DotNet.Arcade.Sdk/tools/ProjectDefaults.props#L32-L33

Windows PDBs were originally produced to support tools like WinDbg and Watson. From what I see, both of these tools already support portable PDBs. I.e.: https://github.com/MicrosoftDocs/windows-driver-docs/blob/staging/windows-driver-docs-pr/debugger/symbols-portable-pdb.md#portable-pdb-symbols

Roslyn, razor and maybe others also don't produce them anymore: https://github.com/dotnet/roslyn/pull/64581

Unless someone still knows reasons to keep producing Windows PDBs, we should disable the conversion and remove the associated infrastructure. Bonus: This also removes differences in the VMR build which currently disables the windows PDB generation in three repos: https://github.com/search?q=repo%3Adotnet%2Fsdk%20PublishWindowsPdb&type=code

cc @mmitche @akoeplinger @tmat

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.