dotnet / dotnet/arcade

DotNetPublishUsingPipelines removal caused some repos to start publishing -ci packages

Open
#15,641 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C#
Stars
729
Forks
397
Avg merge
3d 15m
Merged PRs (30d)
149

Description

DotNetPublishUsingPIpelines unintentionally meant "publishing or not". DotNetPublishUsingPipelines should never have been used to differentiate actually publishing vs. not. It was only used to differentiate two types of publishing, and it was originally supposed to be removed when we moved from V2 publishing to V3. This has been lurking for a LONG time.

Not all repos hit this:

Lots of repos deal with publishing in different ways:
- They only build things that should publish in their official builds - I think this is the case for most repos.
- They don't use cibuild.cmd, and do not pass --publish in their official build for legs that should not publish.

**Proposed Solutions:**

- Remove -publish from cibuild.cmd/sh - Pass explicitly where necessary.
- Change repos that build a surplus in their official builds to use eng/common/build.sh/cmd and only pass -publish in the legs that should publish

**Preferred Solution:**

I favor the first option if cibuild.cmd is sparingly used through the .NET ecosystem. We can fix up the few cases that use it. I favor the second if cibuild.cmd is used in lots of places, but where most repos are only building what they need want to ship in their official builds.

Need to first investigate what repos are doing.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.