dotnet / dotnet/arcade

Should ConditionalClass and similar attributes in XUnitExtensions filter tests out automatically?

Open
#15,195 4 comments 4 reactions 0 assignees View on GitHub
Dominant language
C#
Stars
729
Forks
397
Avg merge
3d 15m
Merged PRs (30d)
149

Description

ConditionalClass and similar attributes add a `failing` trait to the tests that should conditionally not run: https://github.com/dotnet/arcade/blob/1ccd352f12e845d89e5b5a9b800e2be88f8a6d98/src/Microsoft.DotNet.XUnitExtensions/src/Discoverers/ConditionalClassDiscoverer.cs#L30

It might make sense to automatically filter those out without relying on the test settings to exclude the `failing` trait (i.e. in a .runsettings file).

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.