dotnet / dotnet/arcade

Do not use a default value for MicrosoftNetCompilersToolsetVersion

Open
#15,182 0 comments 0 reactions 0 assignees View on GitHub
up-for-grabs
Dominant language
C#
Stars
729
Forks
397
Avg merge
3d 15m
Merged PRs (30d)
149

Description

- [ ] This issue is blocking
- [x] This issue is causing unreasonable pain

It looks like Versions.props [specifies an old version of the Toolset package](https://github.com/dotnet/arcade/blob/ad64a76fd00a641116e79f77d48b42c6e7ed9b0a/eng/Versions.props#L45). 4.8 at time of writing.

What this means is that if user has set property `UsingToolMicrosoftNetCompilers=true`, then this old version of the package is used by default. This is causing the user to use an older compiler than the one in the included .NET SDK, which is not supported.

This should be fixed by deleting the version of the Toolset in Versions.props. This should cause the build to fail when `UsingTool...` is set without also explicitly setting the tool version. Optionally, some more descriptive warning could also be reported in this case, in order to make it more clear how to fix it.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.