dotnet / dotnet/arcade

VerifyClosure doesn't handle resource dlls

Open
#1,490 0 comments 0 reactions 0 assignees View on GitHub
area-Infrastructure-libraries help wanted
Dominant language
C#
Stars
729
Forks
397
Avg merge
3d 15m
Merged PRs (30d)
149

Description

Since VerifyClosure indexes assemblies by simple name it halts when it sees two resource assemblies (that differ only in culture).

https://github.com/dotnet/arcade/blob/fe25f076bdd44568aa6334d4266e6553719cf91d/src/Microsoft.DotNet.Build.Tasks.Packaging/src/VerifyClosure.cs#L105-L122

We could change this to index by the assemblyname, culture, and public key token. to address this.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.