dotnet / dotnet/arcade

SDL - "Trim the version from the nuget packages" step creates a cyclic dependency in Arcade

Open
#14,287 4 comments 1 reaction 0 assignees View on GitHub
area-product-construction
Dominant language
C#
Stars
729
Forks
397
Avg merge
3d 15m
Merged PRs (30d)
149

Description

See the failing builds that started happening when upgrading the .NET SDK to .NET 9: https://dnceng.visualstudio.com/internal/_build/results?buildId=2335177&view=logs&j=7d9eef18-6720-5c1f-4d30-89d7b76728e9&t=c49a855a-1eb9-5019-62bf-639a659fe361

A prebuilt version of `Microsoft.DotNet.VersionTools.Cli` is used based on the Arcade.Sdk version string: https://github.com/dotnet/arcade/blob/4b9b42786eec238bbddcf85fb8c888ce95751268/eng/common/sdl/trim-assets-version.ps1#L55

That prebuilt package depends on the SDK / runtime being installed that the CLI tools was compiled against (cause framework-dependent deployment). In this case the tool is compiled against net8.0 but the .NET 9 SDK is installed so the 8.0 runtime is missing.

We could allow the tool to roll forward to the next major version or to install the corresponding SDK for the tool.

I will add the roll forward switch for now to unblock the official builds.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.