dotnet / dotnet/arcade

Using dotnet SDK from PATH when global_json_has_runtimes

Open
#14,096 2 comments 0 reactions 0 assignees View on GitHub
help wanted
Dominant language
C#
Stars
729
Forks
397
Avg merge
3d 15m
Merged PRs (30d)
149

Description

arcade defaults to want to use the dotnet that is on PATH if it matches the global.json SDK version:

https://github.com/dotnet/arcade/blob/3fe889b2724f312ba0dec7c01d85e9257e38818e/eng/common/tools.sh#L54

but that doesn't work when the global.json files has a `tools.runtimes` section:

https://github.com/dotnet/arcade/blob/3fe889b2724f312ba0dec7c01d85e9257e38818e/eng/common/tools.sh#L131-L138

This is the case for aspnetcore: https://github.com/dotnet/aspnetcore/blob/480683e067ec01616eef758f8b0a4f968bf9fbee/global.json#L7C6-L7C14.

Could we extend this condition so that when `DotNetBuildFromSource` is set to `true` that the sdk on path does get used?
Does that make sense?

cc @MichaelSimons @premun

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.