dotnet / dotnet/arcade-services

Maestro should re-evaluate merge policies based on latest PR merge commit

Open
#3,036 2 comments 1 reaction 0 assignees View on GitHub
Dominant language
C#
Stars
86
Forks
86
Avg merge
1d 8h
Merged PRs (30d)
35

Description

### Release Note Category
- [x] Feature changes/additions
- [ ] Bug fixes
- [ ] Internal Infrastructure Improvements

Right now, Maestro appears to only evaluate merge policies (at least the coherency ones?) on new pushes by Maestro. Because maestro pushes do not take into account what the user has pushed to a PR in the meantime (maybe this should change?) this means that if a user fixed coherency issues on the PR source branch, the check will remain failed.

This is confusing behavior for users. I think ideally you would want to re-evaluate the check based on the latest pushes.

### Release Note Description

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.