dotnet / dotnet/arcade-services

NuGet.config isolated package sources comments being deleted when package sources are removed.

Open
#2,517 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
C#
Stars
86
Forks
86
Avg merge
1d 8h
Merged PRs (30d)
35

Description

- [ ] This issue is blocking
- [ ] This issue is causing unreasonable pain

Maestro adds the following entries when adding isolated package sources:

```
+
+
+
```

These are properly alphabetized. The point of the comments is that over time, we will get fewer merge conflicts between internal and external, or between multiple PRs coming into various repos that edit the same section. Separate PRs will edit separate sections and will not conflict.

When a package source is removed today (e.g. after release day), Maestro is deleting the comment:

```
--
--
--
+
+
+
```

This is not desired. The goal here is that this section over time ends up stable (contains a comment block every repo that could **possibly** have a stable feed. And those stable feeds are either present or not. Removing the entries means that they will have to be re-introduced later, which will likely cause conflicts. Instead, When the roslyn-analyzers entry is no longer needed, Maestro should leave a blank space or remove the feed with a comment. For example it might.

```
!-- Begin: Package sources from dotnet-roslyn-analyzers -->

```

The intention of the feature is that separate PRs should not generate merge conflicts in the nuget.config file

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.