dotnet / dotnet/arcade-services

Visual Studio insertions in the staging pipeline should re-version packages on collision

Open
#2,475 4 comments 0 reactions 0 assignees View on GitHub
Dominant language
C#
Stars
86
Forks
86
Avg merge
1d 8h
Merged PRs (30d)
35

Description

- [ ] This issue is blocking
- [ ] This issue is causing unreasonable pain

When as rerun of the staging pipeline is done for a release, and there is no new runtime in the rerun, the relink of MSIs changes behavior. this is fine, except that VS pulls in these MSIs via VS.Redist.* nuget packages, which have already been pushed on the first staging pipeline run. This can cause major issues.

To fix this:
* When pushing to the VS feed
* If the packages already exist on the feed **and** they are not identical (bit for bit), alter the version number of the package in some way (e.g. alter the pre-release label to be servicing-1, servicing-2, etc.) to avoid collisions.
* Push new packages to VS feed.
* Open VS insertion PRs using the new version number.

The updated packages don't need to be re-signed, however there is some level of mechanics here. The manifests for the build, which drive the VS insertion, will mention the old package IDs. There may also be other downstream effects in places that the manifest is in use.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.