dotnet / dotnet/android-libraries

Some methods require a parameter of type Java.Lang.Boolean instead of .NET Boolean in Firebase Crashlytics and Perf bindings

Open
#992 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
C#
Stars
317
Forks
73
Avg merge
1d 8h
Merged PRs (30d)
17

Description

### Android application type

Android for .NET (net6.0-android, etc.)

### Affected platform version

.NET 8.0.402

### Description

There are two methods which I currently know of that require a parameter of type `Java.Lang.Boolean` rather than .NET Boolean.

In Xamarin.Firebase.Crashlytics v119.1.0, `FirebaseCrashlytics.Instance.SetCrashlyticsCollectionEnabled` expects a `Java.Lang.Boolean?` parameter while v119.0.3.1 had a .NET Boolean parameter.

`FirebasePerformance.Instance.SetPerformanceCollectionEnabled` of Xamarin.Firebase.Perf has the same issue as well where it expects a `Java.Lang.Boolean` instead of a .NET Boolean type, but this has been like this for quite a while.

### Steps to Reproduce

1. Add Xamarin.Firebase.Crashlytics v119.1.0 or Xamarin.Firebase.Perf v121.0.0
2. Call the above mentioned methods in Description
3. See that they require a parameter of type `Java.Lang.Boolean` instead of a .NET Boolean

### Did you find any workaround?

Use `Java.Lang.Boolean.ValueOf()`

### Relevant log output

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.