dotnet / dotnet/TorchSharp

Adding Logging - Serilog vs Microsoft.Extensions.Logging

Open
#1,557 0 comments 0 reactions 0 assignees View on GitHub
question
Dominant language
C#
Stars
1.9k
Forks
228
PR merge metrics
No merged PRs in 30d

Description

This is more of a question of trying to contribute something, please shut this down immediately if it's already been considered or is totally undesirable.

Now the overly simple addition I'm considering is logging of some startup steps and possibly the start of a training, end, and possibly checkpoints. It'd all be rather light to avoid a situation where performance tracking clearly shows logging's to blame.

The second question is, if this is at all desirable: Serilog or Microsoft.Extensions.Logging? My thoughts are towards the latter for this project given that you're keeping dependencies to a minimum, but the tradeoff is that there'd be a static class to inject a logger early on if desired. Serilog would give that to us for free. I'm thinking either way should be pretty easy and light with most messages going to Trace.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.