dotnet / dotnet/TorchSharp

Modernize torchsharp infrastructure

Open
#1,346 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
C#
Stars
1.9k
Forks
228
PR merge metrics
No merged PRs in 30d

Description

In looking at Torchsharp's build I had a few thoughts for improvement.

- [ ] Evaluate using arcade and provided build templates.
- [ ] Remove as much as possible from the YML and have it be part of the local build scripts so that it's easier to repro things that are hit by the official build.
- [ ] Remove use of the `nupkgproj` and instead pack from the CProj projects where possible
- [ ] For the remaining `nupkgproj` have them use the Microsf.Build.NoTargets SDK to avoid C# specific targets.
- [ ] Add all projects to the SLN, and control the pack behavior with `IsPackable` conditions rather than conditions in a project https://github.com/dotnet/TorchSharp/blob/077780db89bfc7671af6262ed817e30cb14cf4d3/pkg/pack.proj#L4
- [ ] Adopt package readme's following a similar convention to dotnet\runtime.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.