dotnet / dotnet/SqlClient

Question: Get rid of NameValuePair _keyChain field in DbConnectionOptions.Common.cs

Open
#682 6 comments 0 reactions 0 assignees View on GitHub
Code Health :pill: Performance :chart_with_upwards_trend:
Dominant language
C#
Stars
989
Forks
340
Avg merge
4d 19h
Merged PRs (30d)
72

Description

In DbConnectionOptions there are two quite similar structures to store connection string Key/Value pairs.
The main difference that I can see is only the order.
Is it really critical to show values as passed from user(password replaced with *), or it doesn't matter ?

File: DbConnectionOptions.Common.cs
Fields:
`
private readonly Dictionary _parsetable;

internal readonly NameValuePair _keyChain;
`

If I comment _keyChain - it looks to be used only in **ExpandAttachDbFileName** and **ReplacePasswordPwd**.
Both can be mimic with _parsetable.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.