dotnet / dotnet/SqlClient

Make internal constructors public

Open
#465 9 comments 2 reactions 0 assignees View on GitHub
Dominant language
C#
Stars
989
Forks
340
Avg merge
4d 19h
Merged PRs (30d)
72

Description

I want to create a derived class from the `SqlDataReader` but unfortunately its constructor is marked as `internal`.
```csharp
internal SqlDataReader(SqlCommand command, CommandBehavior behavior)
```
Making it `public` can be useful for mocking, overriding some of its methods, without using reflection, proxy libraries and so on. It would be great if this library uses the same approach as the EF-Core team is doing, by not defining `internal` types.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.