dotnet / dotnet/Silk.NET

CmdUpdateBuffer pData parameter should be const

Open
#981 3 comments 1 reaction 0 assignees View on GitHub
area-SilkTouch area-Vulkan enhancement
Dominant language
C#
Stars
5.2k
Forks
477
Avg merge
3d 16h
Merged PRs (30d)
2

Description

# Summary
The generated bindings for [`vkCmdUpdateBuffer`](https://registry.khronos.org/vulkan/specs/1.3-extensions/man/html/vkCmdUpdateBuffer.html) have the `pData` parameter marked as [`ref`](https://github.com/dotnet/Silk.NET/blob/main/src/Vulkan/Silk.NET.Vulkan/Vk.gen.cs#L1422) (or [`Span`](https://github.com/dotnet/Silk.NET/blob/main/src/Vulkan/Silk.NET.Vulkan/VkOverloads.gen.cs#L1402) for the Span overloads), rather than `in` or `ReadOnlySpan`. The official documentation for [`vkCmdUpdateBuffer`](https://registry.khronos.org/vulkan/specs/1.3-extensions/man/html/vkCmdUpdateBuffer.html) has the `pData` parameter marked const.

These parameters should be treated like other `const` parameters, and take an `in` or `ReadOnlySpan` argument.

# Steps to reproduce
N/A

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.