dotnet / dotnet/EntityFramework.Docs

Spatial Data in the SQL Server EF Core Provider - NetTopologySuite does NOT guarantee valid geography objects

Open
#3,958 0 comments 0 reactions 0 assignees View on GitHub
area-spatial
Dominant language
Mermaid
Stars
1.7k
Forks
2k
Avg merge
7d 23h
Merged PRs (30d)
16

Description

Section *Geography polygon rings*:

Please correct me if I am wrong. But both [NetTopologySuite](https://nettopologysuite.github.io/NetTopologySuite/) and [Microsoft.EntityFrameworkCore.SqlServer.NetTopologySuite](https://www.nuget.org/packages/Microsoft.EntityFrameworkCore.SqlServer.NetTopologySuite) do not produce Polygons with the correct orientation.

This was also explicitly mentioned here: https://github.com/NetTopologySuite/NetTopologySuite/issues/387#issuecomment-592516071

I think that the functionality should be implemented in [Microsoft.EntityFrameworkCore.SqlServer.NetTopologySuite](https://www.nuget.org/packages/Microsoft.EntityFrameworkCore.SqlServer.NetTopologySuite) in order to ensure correct orientation.

In the meantime, we should remove the last sentence ("[NetTopologySuite](https://nettopologysuite.github.io/NetTopologySuite/) (NTS) validates this before sending values to the database.")

---
#### Document Details

* ID: 4424e4a5-94aa-c681-7681-b3c3e4d99f5f
* Version Independent ID: 6380bd89-78b0-7797-15a3-0629b74c71d2
* Content: [Microsoft SQL Server Database Provider - Spatial Data - EF Core](https://docs.microsoft.com/en-us/ef/core/providers/sql-server/spatial#feedback)
* Content Source: [entity-framework/core/providers/sql-server/spatial.md](https://github.com/dotnet/EntityFramework.Docs/blob/main/entity-framework/core/providers/sql-server/spatial.md)
* Product: **entity-framework**
* Technology: **entity-framework-core**
* GitHub Login: @bricelam
* Microsoft Alias: **avickers**

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.