dotnet / dotnet/EntityFramework.Docs

Unclear wording in filter include

Open
#3,427 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Mermaid
Stars
1.7k
Forks
2k
Avg merge
7d 23h
Merged PRs (30d)
16

Description

The text about repeated filtered includes reads (excluding the examples):

> Each included navigation allows only one unique set of filter operations. In cases where multiple Include operations are applied for a given collection navigation (blog.Posts in the examples below), filter operations can only be specified on one of them: [...]
> Instead, identical operations can be applied for each navigation that is included multiple times: [...]

I think the intent is that either example is valid, and it seems that way from trying them, but I don't think it's clear that that's the case. If this is intended, perhaps something like:

> In cases where multiple Include operations are applied for a given collection navigation (blog.Posts in the examples below), there are two options. First, filter operations can only be specified on one of them: [...]
> Second, identical operations can be applied for each navigation that is included multiple times: [...]

would be clearer?

---
#### Document Details

⚠ *Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.*

* ID: 25a3ce6e-43ab-e0af-01b3-a82fdaf3cb31
* Version Independent ID: 320e7305-e0a3-a1c6-77f2-1d3029b660b1
* Content: [Eager Loading of Related Data - EF Core](https://docs.microsoft.com/en-us/ef/core/querying/related-data/eager#filtered-include)
* Content Source: [entity-framework/core/querying/related-data/eager.md](https://github.com/dotnet/EntityFramework.Docs/blob/main/entity-framework/core/querying/related-data/eager.md)
* Product: **entity-framework**
* Technology: **entity-framework-core**
* GitHub Login: @roji
* Microsoft Alias: **avickers**

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.