dotnet / dotnet/EntityFramework.Docs
Possible mistakes in Connection Resiliency example
- Dominant language
- Mermaid
- Stars
- 1.7k
- Forks
- 2k
- Avg merge
- 7d 23h
- Merged PRs (30d)
- 16
Description
In the section "Option 3 - Add state verification", the code block uses `verifySucceeded` to check if a `Blog` exists with a`BlogId` equal to `blogToAdd.BlogId`. Due to `acceptAllChangesOnSuccess` being set to false, I believe the store-generated `blogToAdd.BlogId` will still be 0 at this point and this check will always fail, or at least will be the wrong check to make. There could be a few ways to improve the example but one might be to use `db.Entry(blogToAdd).CurrentValues[nameof(Blog.BlogId)]` as I think this will have the store-generated value in it.
Also, if my understanding is correct, `AsNoTracking()` is redundant here as no entity is returned by the query. Would it be best to remove this, not just for brevity but so as to avoid any confusion about its function?
---
#### Document Details
⚠ *Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.*
* ID: 876c88d4-2972-d905-28d7-56f9e589f309
* Version Independent ID: 29002343-fa42-2f49-3362-53592039b26d
* Content: [Connection Resiliency - EF Core](https://docs.microsoft.com/en-us/ef/core/miscellaneous/connection-resiliency)
* Content Source: [entity-framework/core/miscellaneous/connection-resiliency.md](https://github.com/dotnet/EntityFramework.Docs/blob/main/entity-framework/core/miscellaneous/connection-resiliency.md)
* Product: **entity-framework**
* Technology: **entity-framework-core**
* GitHub Login: @AndriySvyryd
* Microsoft Alias: **avickers**
Contributor guide
Assessment
This issue has not been assessed yet.