dotnet / dotnet/Docker.DotNet

Why does GetContainerLogs API have a tty parameter?

Open
#440 5 comments 0 reactions 0 assignees View on GitHub
Dominant language
C#
Stars
2.4k
Forks
416
PR merge metrics
No merged PRs in 30d

Description

In order to fix an issue related to garbage characters in the logs stream someone introduced a new API that has a bool tty argument. My understanding is that if the container is create with a tty stdout and stderr are merged. however if the container is created without a tty the two streams are separate and there is a need of multiplexing. Under this light introducing a tty bool argument to the GetContainerLogs API seems wrong as it's driven by a property of the container. There should be no tty argument and the implementation should query whether the container was created with a tty parameter in order to determine the whether multiplexing is needed.

https://github.com/dotnet/Docker.DotNet/commit/adeaacd990bf365f96a0df3999681d7556c29ffb

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.