dotnet / dotnet/Docker.DotNet

BuildImageFromDockerfileAsync is passing AuthConfigs not as Header X-Registry-Config.

Open
#417 0 comments 3 reactions 0 assignees View on GitHub
Dominant language
C#
Stars
2.4k
Forks
416
PR merge metrics
No merged PRs in 30d

Description

According to the documentation of the Docker API the AuthConfigs for other registries need to be passed as Header X-Registry-Config (https://docs.docker.com/engine/api/v1.40/#operation/ImageBuild), but they are passed as normal parameters (https://github.com/microsoft/Docker.DotNet/blob/5cb89ed1c8630d8c2077135e4048290076f808f0/src/Docker.DotNet/Endpoints/ImageOperations.cs#L46)

https://github.com/microsoft/Docker.DotNet/blob/5cb89ed1c8630d8c2077135e4048290076f808f0/src/Docker.DotNet/Models/ImageBuildParameters.Generated.cs#L73

We currently have the issue, that images are pulled from global docker registry, but not from out internal docker registry (even if we are logged in to the registry). Is seems that BuildImageFromDockerfileAsync needs explicit registry auth information. See also https://docs.docker.com/engine/api/v1.40/#section/Authentication

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.