dotnet / dotnet/BenchmarkDotNet

Defaulting NativeAOT to current machines CPU features doesn't represent a real usecase scenario

Open
#2,061 16 comments 2 reactions 0 assignees View on GitHub
Dominant language
C#
Stars
11.5k
Forks
1.1k
Avg merge
4d 11h
Merged PRs (30d)
11

Description

Defaulting to current machines features, introduced in #1994, doesn't seem reasonable to me, since a developer would likely never distribute such build to customers, ignoring servers with known hardware.

As @tannergooding said a few times on the C# discord, comparing a JIT with an AOT using `march=native` isn't meaningful and here we're doing the same.

I'd introduce a separate configuration option `useNativeCpuFeatures` and default that to false to make benchmarking a bit more reasonable.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.