dotnet / dotnet/BenchmarkDotNet

WasmNativeWorkload=false doesn't work in wasm runs

Open
#1,767 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
C#
Stars
11.5k
Forks
1.1k
Avg merge
4d 11h
Merged PRs (30d)
11

Description

To avoid wasm_tools to be required in wasm interpreter and wasm aot runs, the WasmNativeWorkload property should be set to false as below. Even though https://github.com/dotnet/BenchmarkDotNet/blob/f9a4c194b77aa7133168f240b404da58c47d5255/src/BenchmarkDotNet/Templates/WasmCsProj.txt#L16 and https://github.com/dotnet/BenchmarkDotNet/blob/6f453baafa4ef800e0377ebc463ffa82b2f76368/src/BenchmarkDotNet/Templates/WasmAotCsProj.txt#L19 attempted to make the fix, however, it doesn't work for some reason. To temporarily work around this issue, a directory.build.props file had to be inserted to the workitemdirectory of perf run on helix machine, which could have unexpected bad consequences since it is shared by all the perf runs. Fixing this issue is must-to-have. @naricc
```


false

```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.