dotnet / dotnet/AspNetCore.Docs

API Documentation issue in QueryHelpers

Open
#21,721 4 comments 0 reactions 1 assignee Assigned to @v-alje View on GitHub
Pri1
Dominant language
C#
Stars
13.1k
Forks
24.6k
Avg merge
1d 3h
Merged PRs (30d)
97

Description

The [documentation for `QueryHelpers.AddQueryString`](https://docs.microsoft.com/en-us/dotnet/api/microsoft.aspnetcore.webutilities.queryhelpers.addquerystring?view=aspnetcore-5.0) has wrong signatures.

Specifically,
* [`AddQueryString(String, IDictionary)`](https://docs.microsoft.com/en-us/dotnet/api/microsoft.aspnetcore.webutilities.queryhelpers.addquerystring?view=aspnetcore-5.0#Microsoft_AspNetCore_WebUtilities_QueryHelpers_AddQueryString_System_String_System_Collections_Generic_IDictionary_System_String_System_String__) should be `AddQueryString(String, IDictionary)` (with nullable dictionary values)
* [`AddQueryString(String, IEnumerable>)`](https://docs.microsoft.com/en-us/dotnet/api/microsoft.aspnetcore.webutilities.queryhelpers.addquerystring?view=aspnetcore-5.0#Microsoft_AspNetCore_WebUtilities_QueryHelpers_AddQueryString_System_String_System_Collections_Generic_IEnumerable_System_Collections_Generic_KeyValuePair_System_String_System_String___) should be `AddQueryString(String, IEnumerable>)` (with nullable values in the KVP)

It seems these types changed to be nullable with ASP.NET Core 5.0, and I'm referring to the 5.0 documentation.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.