dotansimha / dotansimha/graphql-code-generator

Missing override

Open
#7,478 11 comments 7 reactions 1 assignee Claimed by @kamilkisiela View on GitHub
core stage/1-reproduction stage/4-pull-request
Dominant language
TypeScript
Stars
11.3k
Forks
1.4k
Avg merge
1d 1h
Merged PRs (30d)
23

Description

https://github.com/dotansimha/graphql-code-generator/blob/aeaea1ed1d09172a3bf8a9bd4f1d3cd7ab65023b/packages/plugins/typescript/apollo-angular/src/visitor.ts#L302

Should be fixed to prevent `error TS4114: This member must have an 'override' modifier because it overrides a member in the base class`

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.