dotansimha / dotansimha/graphql-code-generator-community

Doc fix for an extra apostrophe in the code example for additionalDI (apollo-angular config.)

Open
#693 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
137
Forks
195
Avg merge
6h 20m
Merged PRs (30d)
16

Description

### Which packages are impacted by your issue?

@graphql-codegen/typescript-apollo-angular

### Describe the bug

The line currently reads
```typescript
additionalDI: ['testService: TestService', 'testService1': TestService1']
```
Based on the type of `string[]` for `additionalDI`, I believe that the apostrophe after testService1 should be removed.

### Your Example Website or App

https://the-guild.dev/graphql/codegen/plugins/typescript/typescript-apollo-angular#usage-examples-9

### Steps to Reproduce the Bug or Issue

1. Go to https://the-guild.dev/graphql/codegen/plugins/typescript/typescript-apollo-angular#usage-examples-9
2. Observe the code example for additionalDI

### Expected behavior

As a user, I expected to see valid syntax, but I see something that produces a syntax error.

### Screenshots or Videos

_No response_

### Platform

Web

### Codegen Config File

_No response_

### Additional context

The link "Edit this page on Github" is still leading to the original repository: https://github.com/dotansimha/graphql-code-generator, rather than this one. A search of the git log showed the code had been moved here.

The list of possible options on this repository does not include documentation fixes, so I'm submitting this as a "bug."

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.