dotansimha / dotansimha/graphql-code-generator-community

[typescript-urql] useQuery generated hooks are missing argument type

Open
#196 1 comment 1 reaction 0 assignees View on GitHub
Dominant language
TypeScript
Stars
137
Forks
195
Avg merge
6h 20m
Merged PRs (30d)
16

Description

### Describe the bug

The generated `useQuery` hooks only specify one of the two generics. The second one, which is currently missing, defines the argument type for the query and is needed when accessing the arguments on the result object from the query.

### Your Example Website or App

N/A

### Steps to Reproduce the Bug or Issue

No repro needed. The source here is just missing the second argument: https://github.com/dotansimha/graphql-code-generator/blob/master/packages/plugins/typescript/urql/src/visitor.ts#L134

### Expected behavior

The generated code would include all possible generics to make the types as strict as possible.

### Screenshots or Videos

_No response_

### Platform

- OS: N/A
- NodeJS: N/A
- `graphql` version: N/A
- `@graphql-codegen/typescript-urql` version(s): 3.5.12

### Codegen Config File

N/A

### Additional context

_No response_

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.