dotCMS / dotCMS/core

Quality gate — integration-test registration failure mode

Open
#37,581 0 comments 0 reactions 1 assignee View on GitHub

@fabrizzio-dotCMS is already working on this.

Since Sep 16, 2026.

dotCMS : Technical Debt Team : Scout
Dominant language
Java
Stars
970
Forks
486
Avg merge
3d 33m
Merged PRs (30d)
170

Description

Sub-issue of #37124.

Description

Run the monitoring gate on the integration-test registration fix. This is the Rock's flagship failure mode — the concrete example in #37124's own problem statement — and it currently has no owner: Jose merged the fix, but the file lives in Fabrizzio's slice.

What was merged, across two of Jose's milestones:

  • #37127 added the Critical Rule to root CLAUDE.md:71 — a new integration test not added to a MainSuite*/Junit5Suite* @SuiteClasses list compiles fine and is silently never run in CI.
  • #37128 rewrote docs/testing/INTEGRATION_TESTS.md end to end (PR #37506): APITestCase → the real com.dotcms.IntegrationTestBase, the fabricated TestContainers and RestAssured sections removed, -Dtest= → the real -Dit.test=, and a real IntelliJ run/debug workflow added.

The Rock's Definition of Done requires more than the merge: roughly 1–2 weeks of watching real daily PRs and AI-review output, and confirming the failure mode stopped recurring — not just that no one touched the file.

Acceptance Criteria
  • Gate owner agreed between Falcon and Scout (default: Scout, since docs/testing/ is Fabrizzio's slice)
  • Real PRs from the monitoring window reviewed for new integration tests
  • For each one, confirmed the test was registered in a MainSuite*/Junit5Suite* — and if not, whether the doc or the rule failed to reach the author
  • AI-generated test code checked for the retired idioms: APITestCase, BaseContainerTest, TestContainers setup, RestAssured, -Dtest= for integration tests
  • Result recorded here: failure mode confirmed stopped, or reopened with what's still leaking through
Additional Context

Gate outcome feeds condition 2 of #37124's Definition of Done.

Priority

High

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.