dot-analytics: every routed tab reports aria-selected="true"
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 970
- Forks
- 486
- Avg merge
- 3d 33m
- Merged PRs (30d)
- 170
Description
Found while migrating the dotAI portlet (#37417), which copied this pattern.
dot-analytics-dashboard uses routed tabs — <p-tab [routerLink]> inside <p-tabs> with no [value] binding. PrimeNG derives aria-selected from [value], so with none bound every tab renders aria-selected="true" and a screen reader announces all of them as selected.
Verified in the dotAI portlet before the fix: all five tabs reported selected. After binding [value] on <p-tabs> and each <p-tab> — navigation still driven by routerLink, [value] purely for the a11y state — only the active tab reports selected.
Fix in dotAI for reference: 1f2fcd3652.
Note the same shape may exist anywhere else routed p-tabs are used without [value].
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the dot-analytics-dashboard routed tabs, then search for other routed p-tab uses without [value]. Review the p-tabs and p-tab bindings alongside the dotAI reference fix 1f2fcd3652. Done means navigation still works and only the active tab reports aria-selected="true" to assistive technology.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- angular, typescript
- Domain
- accessibility, frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 68/100