dotCMS / dotCMS/core

UVE toolbar copy-URL popover renders without inner padding after the global p-popover padding reset

Open
#37,341 1 comment 0 reactions 1 assignee View on GitHub

@oidacra is already working on this.

Since Sep 2, 2026.

OKR : Customer Support Team : Falcon Type : Defect
Dominant language
Java
Stars
970
Forks
486
Avg merge
3d 33m
Merged PRs (30d)
170

Description

Problem Statement

PR #37034 (Experiments portlet, merged 2026-08-18) made the PrimeNG popover a padding-less panel app-wide: theme.config.ts now sets .p-popover .p-popover-content { padding: 0 } so that each popover's content owns its own spacing. The preset comment records an audit of 24 consumers at the time, and #37247 later restored the padding the toolbar announcements/notifications popovers had lost by wrapping their content in a p-4 container.

The Universal Visual Editor toolbar's copy-URL popover (the link icon next to the page URL, listing Live URL, Current View URL and Site URL with a copy button each) was missed. Its content (.url-list in edit-ema-editor.component.html) has no padding of its own, so the labels, links and copy buttons render flush against the panel edges.

The repo currently has 27 <p-popover> consumer templates, three more than the audit covered, so other popovers may be in the same state.

Impacts every editor using UVE. Cosmetic, but visible on every page edit session. Browser/OS independent (verified on Chrome, macOS).

Steps to Reproduce
  1. Open any page in the Universal Visual Editor (/dotAdmin/#/edit-page/content?url=...).
  2. In the toolbar, click the link icon to the left of the page URL bar.
  3. Observe the popover listing Live URL, Current View URL and Site URL.

Expected: the list sits inside the panel with a 1rem inner padding, the same spacing the toolbar announcements/notifications popovers got in #37247.

Actual: the list touches the panel edges; the copy buttons sit on the right border and the labels on the left border.

Screenshot attached in the linked PR.

Acceptance Criteria
  • The UVE toolbar copy-URL popover renders its Live URL / Current View URL / Site URL list with a 1rem inner padding on all sides, matching the toolbar popovers fixed in #37247.
  • The global rule in theme.config.ts gives .p-popover-content a 1rem padding by default, and drops it structurally when the content's direct child is a p-listbox or p-dataview. A named modifier class (dot-popover-flush) exists for the few consumers that wrap such a component in a layout element; no per-consumer wrapper element or component SCSS is added for padding.
  • The three popovers that carried their own padding wrapper (dot-toolbar-btn-overlay p-4, content-type-field-dragabble-item p-2, dot-content-drive-field-filter p-3) drop the wrapper and rely on the default.
  • Every <p-popover> consumer template in core-web (27 at the time of writing) has been audited; each one is either padded by the default, flush by the structural rule, or flush by dot-popover-flush, and none renders with doubled spacing.
  • The audit result is recorded in the PR description as a table: consumer, affected yes/no, fix applied.
  • Consumers that intentionally render edge-to-edge content (filter panels with listboxes, menus, the theme picker, persona and favorite selectors) are left unchanged and listed as not affected.
  • The copy-URL popover keeps its current behavior: the three URLs open in a new tab, each copy button copies its URL and triggers the copy toast, and the uve-toolbar-copy-url / copy-url-button test ids remain.
  • Existing unit tests for the touched components pass, and any component whose template gains a wrapper element has its spec updated if it queried the previous structure.
dotCMS Version

Latest from main branch (regression introduced by #37034, present after #37247).

Severity

Low - Minor issue or cosmetic

Links
  • Related: #37247 (Toolbar announcements and notifications popovers render without inner padding)
  • Introduced by: #37034 (Experiments portlet with site-wide list screen)
  • NA (no Freshdesk ticket)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.