Nightly build ref: add --first-parent to midnight commit selection
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 970
- Forks
- 486
- Avg merge
- 3d 33m
- Merged PRs (30d)
- 170
Description
Part of dotCMS/private-issues#673.
.github/workflows/cicd_4-nightly.yml:110 selects the build ref with git log --before=midnight -1. Under merge commits, intermediate branch commits are reachable from main, so the nightly can build a mid-branch tree that never existed as main's tip and never passed the merge queue.
Fix: add --first-parent (both the --before lookup and the fallback at line 115). Safe to land now.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open .github/workflows/cicd_4-nightly.yml at lines 110 and 115 and inspect both git log ref-selection commands. Done means both the --before=midnight lookup and its fallback use --first-parent, so nightly selection follows main’s first-parent history rather than an intermediate branch commit.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- git, github-actions
- Domain
- build-system, ci-cd
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Active
- Clarity
- Clearly specified
- Newbie friendliness
- 90/100