dotCMS / dotCMS/core

[30/44] Enable TS strict mode in portlets-dot-es-search-portlet

Open
#35,963 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Team : Maintenance Type : Refactoring
Dominant language
Java
Stars
970
Forks
486
Avg merge
3d 33m
Merged PRs (30d)
170

Description

Description

Part of the strict-mode rollout epic #35932. Enable TypeScript strict mode for the portlets-dot-es-search-portlet project.

  • Internal dependents: 1 · Rollout order: 30 / 44

Note: the original acceptance criteria referenced typescript-strict-plugin, npx tsc-strict, and // @ts-strict-ignore. That approach was dropped by the epic — the plugin was never installed. The ACs below reflect the approach in force, documented in core-web/CLAUDE.mdTypeScript Strict Mode.

Acceptance Criteria

  • The six strict flags are present in the project's own tsconfig.json:
    forceConsistentCasingInFileNames, strict, noImplicitOverride, noPropertyAccessFromIndexSignature, noImplicitReturns, noFallthroughCasesInSwitch.
  • tsc -p <projectRoot>/tsconfig.lib.json --noEmit reports 0 errors (tsconfig.app.json for apps).
  • tsc -p <projectRoot>/tsconfig.spec.json --noEmit reports 0 errors.
  • All errors resolved with explicit types — no new any.
  • nx run <project>:lint and :test pass, with the test count unchanged.
  • nx affected -t build,lint does not break dependents.
  • The enforcement status is recorded — i.e. whether any CI gate actually verifies the strictness.

⚠️ Three things established earlier in this rollout that make error counts untrustworthy:

  • :test does not type-check. isolatedModules: true puts ts-jest in transpile-only mode (#35948), so passing tests say nothing about types. tsc -p is the acceptance test.
  • A files entry pointing at a missing file (TS6053, #35947) or an uninstalled types entry (TS2688, #35944) aborts tsc before semantic checking.
  • tsc does not check templates. Only a build does, and most projects in this rollout have no build target (#35970).

Priority

Medium

Additional Context

One project in the bottom-up rollout tracked by epic #35932.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with core-web/CLAUDE.md under “TypeScript Strict Mode,” then locate portlets-dot-es-search-portlet and inspect its own tsconfig.json, tsconfig.lib.json, and tsconfig.spec.json. Run the specified tsc, Nx lint, test, and affected build/lint commands; done means the six flags are enabled, all checks pass without new any values, test counts are unchanged, dependents remain intact, and enforcement status is recorded.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
build-system, tooling
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.