dotCMS / dotCMS/core

[24/44] Enable TS strict mode in dot-rules

Open
#35,957 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

stale Team : Maintenance Type : Refactoring
Dominant language
Java
Stars
970
Forks
486
Avg merge
3d 33m
Merged PRs (30d)
170

Description

Description

Part of the strict-mode rollout epic #35932. Enable TypeScript strict mode for the dot-rules project using typescript-strict-plugin.

  • Dependency layer: 6 (0 = leaf library, 10 = top-level app)
  • Internal dependents: 2 project(s)
  • Rollout order: 24 / 44

All internal dependencies of dot-rules should already be in strict mode before starting (they appear earlier in the rollout order).

Acceptance Criteria

  • dot-rules's src is added to the typescript-strict-plugin strict paths config.
  • All resulting type errors are resolved (no new any; use explicit types).
  • // @ts-strict-ignore is used only where unavoidable, each with a follow-up TODO.
  • yarn nx run dot-rules:lint passes (and :build / :test where applicable).
  • npx tsc-strict passes for dot-rules.
  • yarn nx affected -t build does not break dependents.

Priority

Medium

Additional Context

One project in the bottom-up rollout tracked by epic #35932. Depends on the bootstrap task being merged and on lower-layer projects already being strict.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the TypeScript strict paths configuration and the dot-rules project's src entry. Add dot-rules to the strict paths, run npx tsc-strict, and resolve the reported errors without new any types. Verify with yarn nx run dot-rules:lint, applicable build and test targets, and yarn nx affected -t build; any unavoidable ignores need follow-up TODOs.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
build-system, tooling
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
50/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.