dotCMS / dotCMS/core

Permissions and Rules dialogs in Edit Content sidebar do not close with ESC key

Open Beginner friendly
#35,267 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

dotCMS: New Edit Contentlet Needs UI Priority : 4 Low stale Team : Falcon Type : Defect
Dominant language
Java
Stars
970
Forks
486
Avg merge
3d 33m
Merged PRs (30d)
170

Description

Problem Statement

The Permissions and Rules dialogs opened from the Edit Content sidebar have closeOnEscape: false explicitly set, which prevents users from closing them with the ESC key. This is inconsistent with the dotCMS global dialog standard, which requires all dialogs to have both closable: true and closeOnEscape: true.

The dialogs can only be closed by clicking the X button, which breaks the expected UX pattern across the application.

Affected components:

  • dot-edit-content-sidebar-permissions.component.ts (line ~53-67) — closeOnEscape: false
  • dot-edit-content-sidebar-rules.component.ts (line ~51-63) — closeOnEscape: false
Steps to Reproduce
  1. Navigate to Edit Content for any contentlet
  2. Open the sidebar
  3. Click on "Permissions" to open the Permissions dialog
  4. Press ESC — dialog does not close
  5. Close the dialog manually with X button
  6. Click on "Rules" to open the Rules dialog
  7. Press ESC — dialog does not close
Acceptance Criteria
  • Permissions dialog in Edit Content sidebar closes when user presses ESC key (closeOnEscape: true)
  • Rules dialog in Edit Content sidebar closes when user presses ESC key (closeOnEscape: true)
  • Both dialogs retain closable: true (X button still works)
  • Unit tests updated to verify closeOnEscape: true configuration
dotCMS Version

Latest from main branch

Severity

Low - Minor issue or cosmetic

Links

NA

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read dot-edit-content-sidebar-permissions.component.ts around lines 53–67 and dot-edit-content-sidebar-rules.component.ts around lines 51–63 to confirm the dialog configuration. Then find the existing unit tests for both components and verify the Permissions and Rules dialogs use closeOnEscape: true while retaining closable: true. Done means both dialogs close with ESC and the tests cover the configuration.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
76/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.