Permissions and Rules dialogs in Edit Content sidebar do not close with ESC key
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 970
- Forks
- 486
- Avg merge
- 3d 33m
- Merged PRs (30d)
- 170
Description
Problem Statement
The Permissions and Rules dialogs opened from the Edit Content sidebar have closeOnEscape: false explicitly set, which prevents users from closing them with the ESC key. This is inconsistent with the dotCMS global dialog standard, which requires all dialogs to have both closable: true and closeOnEscape: true.
The dialogs can only be closed by clicking the X button, which breaks the expected UX pattern across the application.
Affected components:
dot-edit-content-sidebar-permissions.component.ts(line ~53-67) —closeOnEscape: falsedot-edit-content-sidebar-rules.component.ts(line ~51-63) —closeOnEscape: false
Steps to Reproduce
- Navigate to Edit Content for any contentlet
- Open the sidebar
- Click on "Permissions" to open the Permissions dialog
- Press ESC — dialog does not close
- Close the dialog manually with X button
- Click on "Rules" to open the Rules dialog
- Press ESC — dialog does not close
Acceptance Criteria
- Permissions dialog in Edit Content sidebar closes when user presses ESC key (
closeOnEscape: true) - Rules dialog in Edit Content sidebar closes when user presses ESC key (
closeOnEscape: true) - Both dialogs retain
closable: true(X button still works) - Unit tests updated to verify
closeOnEscape: trueconfiguration
dotCMS Version
Latest from main branch
Severity
Low - Minor issue or cosmetic
Links
NA
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read dot-edit-content-sidebar-permissions.component.ts around lines 53–67 and dot-edit-content-sidebar-rules.component.ts around lines 51–63 to confirm the dialog configuration. Then find the existing unit tests for both components and verify the Permissions and Rules dialogs use closeOnEscape: true while retaining closable: true. Done means both dialogs close with ESC and the tests cover the configuration.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 76/100