[DEFECT] Manual deploy workflow (cicd_8-manual-deploy.yml) fails with invalid input parameters
A pull request for this has already been merged.
- #34699 by @spbolton — merged
- Dominant language
- Java
- Stars
- 970
- Forks
- 486
- Avg merge
- 3d 33m
- Merged PRs (30d)
- 170
Description
Problem Statement
The newly created manual deploy workflow (cicd_8-manual-deploy.yml) intended to replace legacy-release_publish-dotcms-docker-image.yml is not functioning correctly. The workflow has multiple issues:
- Validation errors - The workflow fails on startup with parameter errors
- Confusing input options - Some duplication exists in the workflow inputs
- Missing clarity - Branch or tag selection and extension parameter usage is unclear
Error Message:
Invalid workflow file: .github/workflows/cicd_8-manual-deploy.yml#L121
The workflow is not valid.
- .github/workflows/cicd_8-manual-deploy.yml (Line: 121, Col: 11): Input change-detection is required, but not provided while calling.
- .github/workflows/cicd_8-manual-deploy.yml (Line: 123, Col: 25): Invalid input, validation-level is not defined in the referenced workflow.
Impact: Unable to manually deploy Docker images using the new workflow, blocking the deprecation of the legacy workflow.
Steps to Reproduce
- Navigate to Actions tab in dotCMS/core repository
- Select the
cicd_8-manual-deployworkflow - Click "Run workflow"
- Fill in the required parameters
- Click "Run workflow" button
- Observe startup failure with validation errors
Acceptance Criteria
- Fix the
change-detectioninput - either provide required input or make it optional in the called workflow - Remove the invalid
validation-levelinput reference (not defined in referenced workflow) - Simplify and deduplicate input options for clarity
- Ensure branch/tag selection works as expected
- Add clear documentation for the extension parameter
- Verify the workflow runs successfully end-to-end
- Document the migration path from legacy workflow
dotCMS Version
GitHub Actions workflow - main branch (commit c30b53f)
Severity
High - Major functionality broken
Links
- NA (internal engineering issue)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with .github/workflows/cicd_8-manual-deploy.yml, especially the reported errors near lines 121 and 123, and compare it with the referenced legacy workflow. Trace the called workflow's inputs and review the acceptance criteria for branch/tag selection, extension documentation, and migration notes. Verify completion by running the manual deployment workflow end-to-end.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- github-actions
- Domain
- ci-cd
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100