UVE: Remove duplicate dialog instances
Nobody has claimed this yet.
- #32054 by @rjvelazco — closed without merging
- Dominant language
- Java
- Stars
- 970
- Forks
- 486
- Avg merge
- 3d 33m
- Merged PRs (30d)
- 170
Description
Background
DotEmaDialogComponent is instantiated in both EditEmaEditorComponent and DotEmaShellComponent, leading to duplicated state, inconsistent UX, and extra bundle weight. We can centralize dialog control with a shared Angular service.
Task
Remove the two separate instances of DotEmaDialogComponent, there is one inside DotEmaShellComponent and another inside EditEmaEditorComponent. We need to centralize the logic in one component.
Proposed Objective
Same as Parent Issue
Proposed Priority
Priority 3 - Average
Acceptance Criteria
- [ ] Single dialog instance exists in the DOM.
- [ ]
EditEmaEditorComponentandDotEmaShellComponenthave one reference of the same dialog
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate DotEmaDialogComponent usage in DotEmaShellComponent and EditEmaEditorComponent, then inspect how each component controls it. Trace the shared Angular service proposed in the issue and determine which component should own the dialog. Done means only one dialog instance remains in the DOM and both components reference that same instance.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- angular
- Domain
- frontend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100