dotCMS / dotCMS/core

UVE: `variantName` is not being send when saving any content

Open
#31,744 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Team : Scout Type : Defect
Dominant language
Java
Stars
970
Forks
486
Avg merge
3d 33m
Merged PRs (30d)
170

Description

Parent Issue

No response

Problem Statement

We need to ensure that the variantName query parameter is included when calling the /api/v1/workflow/actions/default/fire/EDIT endpoint when the user is inside an Experiment’s Variant. If the user is not inside an Experiment’s Variant, the parameter can be not included.

This must be applied in two places:

  • Inline Editing
  • New Edit Contentlet Portlet

Key Objectives:

  • Add the variantName query parameter when making requests to /api/v1/workflow/actions/default/fire/EDIT from Inline Editing.
  • Add the variantName query parameter when making requests to /api/v1/workflow/actions/default/fire/EDIT from the new Edit Contentlet Portlet.
Steps to Reproduce
  • Strat dotCMS using the full starter.
  • Set the Analytics App and start the Analytics infra.
  • Create an Experiment and a Variant.
  • Edit the Variant
  • Edit a Contentlet using the inline editing
  • Get out of the Experiment and open the page using the DEFAULT Variant
  • You are going to see that the DEFAULT Variant was edit with the change that you do inside the Variant

Include:

  • Inline editing
  • Workflow actions in the page
  • In edit content screen (jsp) is actually working
Acceptance Criteria

Acceptance Criteria:

  • [ ] The variantName query parameter is included in requests to /api/v1/workflow/actions/default/fire/EDIT from Inline Editing, but only when inside an Experiment’s Variant.
  • [ ] The variantName query parameter is included in requests to /api/v1/workflow/actions/default/fire/EDIT from the new Edit Contentlet Portlet, but only when inside an Experiment’s Variant.
  • [ ] The implementation is tested to ensure the parameter is passed correctly when required.
  • [ ] Probably they are more points of saving.
dotCMS Version

latest in main

Proposed Objective

Core Features

Proposed Priority

Priority 2 - Important

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

No response

Assumptions & Initiation Needs

No response

Quality Assurance Notes & Workarounds

No response

Sub-Tasks & Estimates

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the calls to /api/v1/workflow/actions/default/fire/EDIT used by Inline Editing and the new Edit Contentlet Portlet, including the JSP edit-content flow mentioned in the issue. Trace how the current Experiment Variant is identified and run the relevant tests or reproduction steps. Done means variantName is sent only for Variant edits in both specified entry points, without changing the DEFAULT Variant.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.