dortania / dortania/OpenCore-Legacy-Patcher
Bug: DeviceProperty injection issues
- Dominant language
- Python
- Stars
- 18.3k
- Forks
- 2k
- PR merge metrics
- No merged PRs in 30d
Description
With our refactor of DeviceProperty pathing generation, we omit to check if the `acpi-path` entry is present on the device we plan to inject onto. Because of this, our injected properties fail to apply and can result in lose of display output on certain machines (namely those with PCIe bridges on the GPU itself, Vega and Navi series being most prominent)
To resolve, we need to implement the following:
* [x] Verification of `acpi-path`, if omitted fall back on boot-args
* [ ] Add ACPI table building to allow device property injection
ACPI table generation will be exclusive to Mac Pros as they have a known set pathing for their PCIe devices, other devices could be added in the future
Contributor guide
No contributing guide indexed for this repository
Research direction
Start by tracing the DeviceProperty pathing generation and the existing `acpi-path` verification and boot-args fallback. Implement ACPI table building for Mac Pro PCIe paths so device property injection applies reliably, then verify the listed GPU cases no longer lose display output.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- operating-systems
- Issue type
- Bug
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100