doomemacs / doomemacs/core

evil: make minibuffer evilification optional

Open
#7,780 3 comments 0 reactions 0 assignees View on GitHub
:config default is:feature re:evil re:keybinds
Dominant language
Emacs Lisp
Stars
22.7k
Forks
3.1k
Avg merge
10h 46m
Merged PRs (30d)
4

Description

### I confirm that...

- [X] I have searched the [issue tracker](https://github.com/doomemacs/doomemacs/issues), [documentation](https://docs.doomemacs.org), [FAQ](https://docs.doomemacs.org/-/faq), [Discourse](https://discourse.doomemacs.org), and [Google](https://google.com), in case this issue has already been reported/resolved.

- [X] I have read "[How to Debug Issues](https://doomemacs.org/d/how2debug)", and will use it to provide as much information about this issue as possible.

- [X] The issue can be reproduced on the **latest** available commit of Doom.

- [X] The issue can be reproduced on a stable release of Emacs, such as 27, 28, or 29. *(Unstable versions end in .50, .60, or .9x)*

### Expected behavior

I do not want my minibuffer evilifed but I do want `+everywhere` for major modes. There should be an option to leave the default key binds unmodified (e.g. `+minibuffer`).

I generally only want major mode evilification and leader keys.

### Current behavior

Upstream `evil-collection` has `evil-collection-setup-minibuffer` for configuring that aspect but doom-emacs overrides it unconditionally:

https://github.com/doomemacs/doomemacs/blob/5f5a163c49207a7083ab1ecc9e78d268fd6600b8/modules/config/default/%2Bevil-bindings.el#L7-L34

Doom should either respect the upstream variable or have its own variable.

Related issue:

https://github.com/doomemacs/doomemacs/issues/6325

### Steps to reproduce

1. Open Emacs
2. Want evil major modes and leader keys but default keybinds everywhere else
3. Find no option to configure it

### System Information

https://pastebin.com/z6czCYHp

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.