doomemacs / doomemacs/core

mu4e (1.12): broken mu4e-compose-wide-reply

Open
#7,709 1 comment 0 reactions 0 assignees View on GitHub
:email mu4e is:update
Dominant language
Emacs Lisp
Stars
22.7k
Forks
3.1k
Avg merge
10h 46m
Merged PRs (30d)
4

Description

### I confirm that...

- [X] I have searched the [issue tracker](https://github.com/doomemacs/doomemacs/issues), [documentation](https://docs.doomemacs.org), [FAQ](https://docs.doomemacs.org/-/faq), [Discourse](https://discourse.doomemacs.org), and [Google](https://google.com), in case this issue has already been reported/resolved.
- [X] I have read "[How to Debug Issues](https://doomemacs.org/d/how2debug)", and will use it to provide as much information about this issue as possible.
- [X] The issue can be reproduced on the **latest** available commit of Doom.
- [X] The issue can be reproduced on a stable release of Emacs, such as 27, 28, or 29. *(Unstable versions end in .50, .60, or .9x)*

### Expected behavior

Wide reply (reply all) does work and will create new window where I can write my email with all the addresses for reply all functionality. It is also bound to some key so I can run it without `M-x`.

### Current behavior

I use `M-x mu4e-compose-wide-reply`. I get error:

``` elisp
Debugger entered--Lisp error: (wrong-type-argument number-or-marker-p wide)
/=(1 wide)
(+mu4e-compose-org-msg-handle-toggle (/= 1 (or toggle-p 0)))
+mu4e-maybe-toggle-org-msg-a(#f(advice +mu4e-ensure-compose-writeable-a :before #) wide)
apply(+mu4e-maybe-toggle-org-msg-a #f(advice +mu4e-ensure-compose-writeable-a :before #) wide)
mu4e-compose-reply(wide)
mu4e-compose-wide-reply()
funcall-interactively(mu4e-compose-wide-reply)
command-execute(mu4e-compose-wide-reply record)
execute-extended-command(nil "mu4e-compose-wide-reply" #("wid" 0 3 (ws-butler-chg chg)))
funcall-interactively(execute-extended-command nil "mu4e-compose-wide-reply" #("wid" 0 3 (ws-butler-chg chg)))
command-execute(execute-extended-command)
```

I do compose my emails in plain text, my quick hotfix is to comment out the advice +mu4e-maybe-toggle-org-msg-a around mu4e-compose-new and mu4e-compose-reply in `modules/email/mu4e/config.el`. (To get this working I needed to comment out even `mu4e-clear-caches` in `modules/email/mu4e/autoload/email.el`, which is referenced in #7703 )

Now the `mu4e-compose-wide-reply` runs `mu4e-compose-reply` with `wide` which I think has been used previously to toggle the org/plain email composing.

With this change in mu4e 1.12 It seems that some update of keybindings will be required also as "wide reply" is not bound to anything (personally I liked the old behavior better).

### Steps to reproduce

- open mu4e and browse email
- run `M-x mu4e-compose-wide-reply` on any email
- observe error

### System Information

https://pastebin.com/VKnr5eTj

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.