doomemacs / doomemacs/core

org-download uses wrong url type when "org-download-method 'directory" is set

Open
#7,269 0 comments 2 reactions 0 assignees View on GitHub
is:bug needs-triage
Dominant language
Emacs Lisp
Stars
22.7k
Forks
3.1k
Avg merge
10h 46m
Merged PRs (30d)
4

Description

### I confirm that...

- [X] I have searched the [issue tracker](https://github.com/doomemacs/doomemacs/issues), [documentation](https://docs.doomemacs.org), [FAQ](https://docs.doomemacs.org/-/faq), [Discourse](https://discourse.doomemacs.org), and [Google](https://google.com), in case this issue has already been reported/resolved.

- [X] I have read "[How to Debug Issues](https://doomemacs.org/d/how2debug)", and will use it to provide as much information about this issue as possible.

- [X] The issue can be reproduced on the **latest** available commit of Doom.

- [X] The issue can be reproduced on a stable release of Emacs, such as 27 or 28. *(Doom does not support development builds like 29+ or any version ending in .50 or .9x)*

### Expected behavior

Running `org-download-clipboard` should add a link as `file:` type url when setting `org-download-method 'directory`

### Current behavior

Running `org-download-clipboard` adds a link as `download:` type url instead.

This breaks inline image display and exports to latex, pdf, html etc. (as reported [here](https://github.com/abo-abo/org-download/issues/151))

### Steps to reproduce

1. Add this to `config.el`:

````
(after! org-download
(setq org-download-method 'directory)
(setq org-download-image-dir (concat (file-name-sans-extension (buffer-file-name)) "-img"))
(setq org-download-image-org-width 600))
````
2. open an `.org` file
3. add an image to your clipboard
4. run `org-download-clipboard`
5.* run `org-toggle-inline-images` if needed to see the link

Also to solve this add these three lines to the above `after! `block (as mentioned [here](https://github.com/abo-abo/org-download/issues/151#issuecomment-1425096926)):
````
(setq org-download-link-format "[[file:%s]]\n"
org-download-abbreviate-filename-function #'file-relative-name)
(setq org-download-link-format-function #'org-download-link-format-function-default)
````

### System Information

https://pastebin.com/a52p74Aw

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.