doomemacs / doomemacs/core

Workspace stays open after git commit

Open
#7,209 1 comment 0 reactions 0 assignees View on GitHub
is:bug needs-triage
Dominant language
Emacs Lisp
Stars
22.7k
Forks
3.1k
Avg merge
10h 46m
Merged PRs (30d)
4

Description

### I confirm that...

- [X] I have searched the [issue tracker](https://github.com/doomemacs/doomemacs/issues), [documentation](https://docs.doomemacs.org), [FAQ](https://docs.doomemacs.org/-/faq), [Discourse](https://discourse.doomemacs.org), and [Google](https://google.com), in case this issue has already been reported/resolved.

- [X] I have read "[How to Debug Issues](https://doomemacs.org/d/how2debug)", and will use it to provide as much information about this issue as possible.

- [X] The issue can be reproduced on the **latest** available commit of Doom.

- [X] The issue can be reproduced on a stable release of Emacs, such as 27 or 28. *(Doom does not support development builds like 29+ or any version ending in .50 or .9x)*

### Expected behavior

In my setup I'm using Doom Emacs from the terminal. I have `magit` and `:ui/workspaces` enabled. `$EDITOR` is set to `emacsclient -nw`, so that when I run `git commit`, it pops open an emacs frame in the terminal, in magit mode, I write the commit message, and `C-c C-c` to finish.

Normally when I open emacs in a terminal frame via `emacsclient`, it opens the file argument in a new workspace. When I close the frame via `C-x C-c`, it also deletes the workspace. However, when emacs is opened via `git commit`, the workspace isn't deleted after finishing the commit message (`C-c C-c`).

It's pretty annoying to have a bunch of empty workspaces hanging around after a few commits - appreciate any help!

---
```
❯ doom info
generated Apr 26, 2023 19:26:24
system MacOS 13.2.1 Darwin 22.3.0 arm64
emacs 28.3 ~/.config/emacs/
doom 3.0.0-pre PROFILE=_@0 HEAD -> master 042fe0c4 2023-04-12 15:09:23
-0400 ~/.config/doom/
shell /bin/zsh
features ACL GMP GNUTLS JSON LIBXML2 MODULES NOTIFY KQUEUE PDUMPER THREADS
TOOLKIT_SCROLL_BARS XIM ZLIB
traits batch server-running envvar-file custom-file
modules :config use-package :completion company vertico :ui doom
doom-dashboard doom-quit (emoji +github +unicode) hl-todo ligatures
minimap modeline ophints (popup +defaults) treemacs (vc-gutter
+pretty) vi-tilde-fringe workspaces :editor file-templates fold
snippets :emacs dired electric undo vc :checkers syntax :tools (eval
+overlay) lookup lsp magit :os macos tty :lang (cc +lsp) clojure data
emacs-lisp json javascript markdown org python sh web yaml :config
(default +bindings +smartparens)
```

Emacs is the Homebrew-installed railwaycat version, `emacs-mac`.

### Current behavior

see above

### Steps to reproduce

1. git commit
2. edit commit in magit mode, `C-c C-c`
3. notice later that an empty workspace is hanging around

### System Information

https://gist.github.com/jimbru/54b5b1fc94f8ca095200d7cd5f1c64d5

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.