doomemacs / doomemacs/core

eshell-previous-prompt broken on Emacs 30

Open
#7,131 0 comments 0 reactions 0 assignees View on GitHub
is:bug needs-triage
Dominant language
Emacs Lisp
Stars
22.7k
Forks
3.1k
Avg merge
10h 46m
Merged PRs (30d)
4

Description

### I confirm that...

- [X] I have searched the [issue tracker](https://github.com/doomemacs/doomemacs/issues), [documentation](https://docs.doomemacs.org), [FAQ](https://docs.doomemacs.org/-/faq), [Discourse](https://discourse.doomemacs.org), and [Google](https://google.com), in case this issue has already been reported/resolved.

- [X] I have read "[How to Debug Issues](https://doomemacs.org/d/how2debug)", and will use it to provide as much information about this issue as possible.

- [X] The issue can be reproduced on the **latest** available commit of Doom.

- [X] The issue can be reproduced on a stable release of Emacs, such as 27 or 28. *(Doom does not support development builds like 29+ or any version ending in .50 or .9x)*

### Expected behavior

In Emacs 30, `eshell-prompt-regexp` has been declared obsolete and searching for prompts is done using text properties now, as below
![image](https://user-images.githubusercontent.com/29102529/222621666-58a168f4-0352-4642-8ae2-81915b90dd6c.png)
The issue is that now `eshell-previous-prompt` is broken because of the newline character `+eshell-default-prompt-fn` inserts in the beginning. I propose removing the `(if (bobp) "" "\n")` from the Eshell prompt function.

### System Information

https://pastebin.com/3EgWg6NR

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.