doomemacs / doomemacs/core

Unfocusing Emacs disturbs buffer text layout by adding border around warning/error faces

Open
#7,121 0 comments 0 reactions 0 assignees View on GitHub
is:bug needs-triage
Dominant language
Emacs Lisp
Stars
22.7k
Forks
3.1k
Avg merge
10h 46m
Merged PRs (30d)
4

Description

### I confirm that...

- [X] I have searched the [issue tracker](https://github.com/doomemacs/doomemacs/issues), [documentation](https://docs.doomemacs.org), [FAQ](https://docs.doomemacs.org/-/faq), [Discourse](https://discourse.doomemacs.org), and [Google](https://google.com), in case this issue has already been reported/resolved.

- [X] I have read "[How to Debug Issues](https://doomemacs.org/d/how2debug)", and will use it to provide as much information about this issue as possible.

- [X] The issue can be reproduced on the **latest** available commit of Doom.

- [X] The issue can be reproduced on a stable release of Emacs, such as 27 or 28. *(Doom does not support development builds like 29+ or any version ending in .50 or .9x)*

### Expected behavior

When un/focusing Emacs, buffer text does not shift, change line height, or relayout.

### Current behavior

Emacs wasn't resized between those two screenshots:
Emacs focused
Emacs unfocused

### Steps to reproduce

1. Open a buffer with occurences of the `success`, `warning`, or `error` face (e.g. with `FIXME` comments highlighted by `hl-todo`, or an `;;;###autoload`
2. Unfocus Emacs by seleting another application

Any text with the above faces (or any face that inherits from them) is remapped to a modeline face with wide border.
This causes each of those lines to change height.

Those three faces appear in `doom-modeline--remap-faces` as shown in the screenshots, but wouldn't be added by the iteration just below.

### System Information

https://gist.github.com/cdlm/458fd7f29fc6a9abf14f3910e944f9ff

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.