doomemacs / doomemacs/core

Saving an unchanged file with format on save enabled doesn't format file

Open
#7,060 0 comments 2 reactions 0 assignees View on GitHub
is:bug needs-triage
Dominant language
Emacs Lisp
Stars
22.7k
Forks
3.1k
Avg merge
10h 46m
Merged PRs (30d)
4

Description

### I confirm that...

- [X] I have searched the [issue tracker](https://github.com/doomemacs/doomemacs/issues), [documentation](https://docs.doomemacs.org), [FAQ](https://docs.doomemacs.org/-/faq), [Discourse](https://discourse.doomemacs.org), and [Google](https://google.com), in case this issue has already been reported/resolved.

- [X] I have read "[How to Debug Issues](https://doomemacs.org/d/how2debug)", and will use it to provide as much information about this issue as possible.

- [X] The issue can be reproduced on the **latest** available commit of Doom.

- [X] The issue can be reproduced on a stable release of Emacs, such as 27 or 28. *(Doom does not support development builds like 29+ or any version ending in .50 or .9x)*

### Expected behavior

1. Open an unformatted file
2. Save file without changing it
3. It should be formatted

### Current behavior

1. Open an unformatted file
2. Save file without changing it
3. It is not formatted
4. Run format manually or change file and save
5. It is formatted

This presumably can be fixed by overriding buffer-modified-p function, but I haven't tried it yet.

### Steps to reproduce

1. Open an unformatted file
2. Save file without changing it (with C-x C-s, :w, etc. - it doesn't matter)

### System Information

Tested on two different machines, doesn't work on both. Probably system information is irrelevant here.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.