doomemacs / doomemacs/core

"doom install" ignoring --fonts

Open
#6,937 0 comments 0 reactions 0 assignees View on GitHub
is:bug needs-triage
Dominant language
Emacs Lisp
Stars
22.7k
Forks
3.1k
Avg merge
10h 46m
Merged PRs (30d)
4

Description

### I confirm that...

- [X] I have searched the [issue tracker](https://github.com/doomemacs/doomemacs/issues), [documentation](https://docs.doomemacs.org), [FAQ](https://docs.doomemacs.org/-/faq), [Discourse](https://discourse.doomemacs.org), and [Google](https://google.com), in case this issue has already been reported/resolved.

- [X] I have read "[How to Debug Issues](https://doomemacs.org/d/how2debug)", and will use it to provide as much information about this issue as possible.

- [X] The issue can be reproduced on the **latest** available commit of Doom.

- [X] The issue can be reproduced on a stable release of Emacs, such as 27 or 28. *(Doom does not support development builds like 29+ or any version ending in .50 or .9x)*

### Expected behavior

When I pass `--fonts` to `doom install`, it should not prompt me “Download and install all-the-icon's fonts? (y or n)”.

### Current behavior

When I pass `--fonts` to `doom install`, it prompts me “Download and install all-the-icon's fonts? (y or n)”.

### Steps to reproduce

1. Execute this script:
```
#!/bin/bash
( # subshell to avoid taint if you just want to paste this into your Terminal as-is
set -e;
export HOME=$(mktemp -d);
echo "HOME=$HOME";
time ( git clone --depth 1 --single-branch https://github.com/doomemacs/doomemacs ~/.config/emacs && ~/.config/emacs/bin/doom install --no-env --fonts );
emacs
)
```
2. Observe that `--no-env` is respected; the user is _not_ prompted whether to set up an environment file.
3. Observe that `--fonts` is _not_ respected; the user _is_ prompted whether to download and install the icon font pack.

### System Information

http://ix.io/4flm

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.