doomemacs / doomemacs/core

Missing some Deft Mode Mappings

Open
#6,595 5 comments 0 reactions 0 assignees View on GitHub
is:bug needs-triage
Dominant language
Emacs Lisp
Stars
22.7k
Forks
3.1k
Avg merge
10h 46m
Merged PRs (30d)
4

Description

### What did you expect to happen?

After enabling `:ui deft` and entering Deft, either via `SPC n d` or `M-x deft RET`, Doom's keybindings should be in effect, as declared here:
https://github.com/doomemacs/doomemacs/blob/dd83c455bad0c77f6f903242dc7008b2f6bbe06a/modules/ui/deft/config.el#L22-L34

### What actually happened?

None of these keybindings are present upon entering Deft, or when viewing the Deft keybindings using `describe-variable` (in this case, `SPC h v` `deft-mode-map`)

Taken from `describe-variable`:
```
deft-mode-map is a variable defined in deft.el.

Value
backward-button
M-SPC m RET deft-new-file-named
M-SPC m a deft-archive-file
M-SPC m c deft-filter-clear
M-SPC m d deft-delete-file
M-SPC m f deft-find-file
M-SPC m g deft-refresh
M-SPC m l deft-filter
M-SPC m n deft-new-file
M-SPC m r deft-rename-file
M-SPC m s deft-toggle-sort-method
M-SPC m t deft-toggle-incremental-search
M-SPC m RET deft-new-file-named
M-SPC m a deft-archive-file
M-SPC m c deft-filter-clear
M-SPC m d deft-delete-file
M-SPC m f deft-find-file
M-SPC m g deft-refresh
M-SPC m l deft-filter
M-SPC m n deft-new-file
M-SPC m r deft-rename-file
M-SPC m s deft-toggle-sort-method
M-SPC m t deft-toggle-incremental-search
SPC m RET deft-new-file-named
SPC m a deft-archive-file
SPC m c deft-filter-clear
SPC m d deft-delete-file
SPC m f deft-find-file
SPC m g deft-refresh
SPC m l deft-filter
SPC m n deft-new-file
SPC m r deft-rename-file
SPC m s deft-toggle-sort-method
SPC m t deft-toggle-incremental-search
SPC m RET deft-new-file-named
SPC m a deft-archive-file
SPC m c deft-filter-clear
SPC m d deft-delete-file
SPC m f deft-find-file
SPC m g deft-refresh
SPC m l deft-filter
SPC m n deft-new-file
SPC m r deft-rename-file
SPC m s deft-toggle-sort-method
SPC m t deft-toggle-incremental-search
forward-button
SPC m RET deft-new-file-named
SPC m a deft-archive-file
SPC m c deft-filter-clear
SPC m d deft-delete-file
SPC m f deft-find-file
SPC m g deft-refresh
SPC m l deft-filter
SPC m n deft-new-file
SPC m r deft-rename-file
SPC m s deft-toggle-sort-method
SPC m t deft-toggle-incremental-search
C- deft-new-file-named
C-c C-a deft-archive-file
C-c C-c deft-filter-clear
C-c C-d deft-delete-file
C-c C-f deft-find-file
C-c C-g deft-refresh
C-c C-l deft-filter
C-c C-n deft-new-file
C-c C-q quit-window
C-c C-r deft-rename-file
C-c C-s deft-toggle-sort-method
C-c C-t deft-toggle-incremental-search
C-c RET deft-new-file-named
C-o deft-open-file-other-window
C-y deft-filter-yank
DEL deft-filter-decrement
M-DEL deft-filter-decrement-word
RET deft-complete
S- backward-button
```
(Excluded the two buttons with weird unicode characters/keycodes at the bottom, bound to `deft-filter-increment`)

### Describe your attempts to resolve the issue

Copy-pasting the `deft-mode-map` from `modules/ui/deft/config.el` into my `$DOOMDIR/config.el` serves as a workaround that implements the keybindings correctly:

```elisp
(map! :map deft-mode-map
:n "gr" #'deft-refresh
:n "C-s" #'deft-filter
:i "C-n" #'deft-new-file
:i "C-m" #'deft-new-file-named
:i "C-d" #'deft-delete-file
:i "C-r" #'deft-rename-file
:n "r" #'deft-rename-file
:n "a" #'deft-new-file
:n "A" #'deft-new-file-named
:n "d" #'deft-delete-file
:n "D" #'deft-archive-file
:n "q" #'kill-current-buffer)
```

### Steps to reproduce

1. Open Deft
2. Press `escape` to enter normal mode
3. Press `q` to try to quit
4. Observe Deft having not closed

Can also attempt to use other keys such as `C-n` in insert mode, `a` in normal mode, etc.

### System Information

https://pastebin.com/nT2k412C

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.